purduesigbots / pros

Source code for PROS kernel: open source C/C++ development for the VEX V5 microcontroller
https://pros.cs.purdue.edu
Other
259 stars 76 forks source link

🐛Converts appending, and constructors to take in AbstractMotor& instead of MotorGroup& #661

Closed noam987 closed 4 months ago

noam987 commented 4 months ago

Summary:

Converts appending, and constructors to take in AbstractMotor& instead of MotorGroup&

Motivation:

Was an oversight originally. It makes sense that motors and custom abstract motors can be appended to MotorGroups. Note it does NOT call the functions of the references being passed in, it just copies over port and reversal information

References (optional):

Test Plan:

noam987 commented 4 months ago

Passed hardware testing in beta server