search

pure-c / purec

C backend for PureScript
234 stars 8 forks source link

Add example to probe purescript-foldable-traversable C FFI #27

Closed Lupino closed 6 years ago

felixSchl commented 6 years ago

This is fantastic. Thanks for taking this up (and #26). I'll take a closer look after in a fewer hours after work. We're circling in on being able to run against PureScript's test suite soon, which is exciting.

felixSchl commented 6 years ago

I've forked foldable-traversable and refs if you'd like to make a pull request there. We also need to get you onto the contributors list, which does not exist yet. I think copying what the PureScript compiler project does would be desirable? https://github.com/purescript/purescript/blob/master/CONTRIBUTORS.md

Lupino commented 6 years ago

OK

felixSchl commented 6 years ago

You mind adding a couple more tests around empty arrays, and singleton arrays?

felixSchl commented 6 years ago

Please, in the future, do not merge your own pull requests. Let's make sure pull requests are reviewed, well considered, and merged by another party instead. I was holding off on merging these because - while useful during building up the libraries - these examples should really be tests, and they should really live in each of the project's respective repositories. It's OK to keep this for now until we complete #12. Once #12 is done, we should be able to add a Makefile to our dependencies and run the tests there - that's how i was testing purescript-integers and it worked well.