search

pure-c / purec

C backend for PureScript
234 stars 8 forks source link

make for examples no longer works #56

Closed LATBauerdick closed 5 years ago

LATBauerdick commented 5 years ago

Hi -- the new version of target.mk no longer works, neither on mac nor ubuntu Going back to dd6a261 for target.mk, and the tests build again. maybe some external dependency?

Love the project, hope I can be more helpful in the future.

felixSchl commented 5 years ago

Oh that's right, i must've forgotten to update them since moving on to psc-package. I'll fix shortly

felixSchl commented 5 years ago

The examples should be building again on master, but it'll take me a bit longer to patch up the tests. I really need to patch up CI to catch these things.

LATBauerdick commented 5 years ago

Thanks, Felix, I tried again from scratch, but it still does not quite work yet.

I think what's missing is that make needs to run psc-package build --only-dependencies at least once. If I do that by hand in each example it then builds.

BTW: make clean also has a small problem in that it does not remove the .psc-package tree, nor main.out (although it states it would remove *.out).

felixSchl commented 5 years ago

I've addressed the issues you mentioned, but I am not sure what you mean by psc-package build --only-dependencies. Things are working for me after make clean. I will try building from a complete clean checkout later tonight.

LATBauerdick commented 5 years ago

after a clean checkout one still needs to get the package dependencies, so at least one psc-package update or some command like that is needed.

felixSchl commented 5 years ago

psc-package install should work. The tests already do that. Not sure where to put that for the examples. I suppose I could add a target .psc-packages that runs psc-package install and add that as a dependency of the generated main target? That should work

felixSchl commented 5 years ago

Alright, that should do it

LATBauerdick commented 5 years ago

I confirm, works!