search

pure-fish / pure

Pretty, minimal, and fast prompt for Fish shell inspired by sindresorhus/pure
https://pure-fish.github.io/pure/
MIT License
1.24k stars 132 forks source link

Fisher update fails #25

Closed edouard-lopez closed 8 years ago

edouard-lopez commented 8 years ago

I tried to update using

$ fisher update pure

And got:

Updating >> pure
fish: Unknown command '__fisher_path_update /home/elopez/.config/fisherman/cache/pure'
fish: ;__fisher_path_update /home/elopez/.config/fisherman/cache/pure
       ^
No plugins were updated.

@bucaran Should we add a __fisher_path_update function that alias to our installer.fish install_pure function?

ghost commented 8 years ago

@edouard-lopez It seems you are using an older version of Fisherman. Can you update and try again?

EDIT: Also, what version of Fisherman were you using? It seems that's even before 1.0?

ghost commented 8 years ago

Should we add a __fisher_path_update function that alias to our installer.fish install_pure function?

I am not sure what installer.fish does, but I don't think so. If Fisherman fails to update pure, then this is Fisherman's fault right?

I can't repro though:

screen shot 2016-03-16 at 7 43 08 pm
rafaelrinaldi commented 8 years ago

@edouard-lopez Is this a Fisherman specific issue?

ghost commented 8 years ago

@rafaelrinaldi It is.

@edouard-lopez Let's move the discussion to Fisherman or to the slack channel http://join.fisherman.sh please.

rafaelrinaldi commented 8 years ago

@bucaran I just asked because I like to organize issues by tagging them and we have a Fisherman tag. Chill.

ghost commented 8 years ago

Ah, alright then.

edouard-lopez commented 8 years ago

@bucaran got 

$ fisher --version
fisher version 0.7.0
ghost commented 8 years ago

@edouard-lopez Oh, I see. Good old days. Yeah, you need to upgrade, we are 1.3.1 now, and 1.4.0 is already in the oven.

edouard-lopez commented 8 years ago

Fisherman version was indeed problematic. Solved it as follow:

  1. after running fisherman/fisherman#162 solution ;

  2. run update again:

    $ fisher update pure
Updating plugins...
▸ pure
1 plugin/s updated in 6s