Remove Oh My Fish! framework badge

[ghost]

This theme works perfectly with:

• fundle
• Fisherman
• Wahoo

and of course

• Oh My Fish!

Displaying the Oh My Fish! badge could potentially make new users believe that this theme does not work with others systems.

BTW I know the README was generated from a template that includes this badge (or the badges were taken from a template), as I worked in the original ones for Wahoo and also for OMF. I am just posting this to let you know of the issue.

Cheers! :smile:

[oranja]

I am all for healthy competition and agree with @bucaran. It would be more fair to list the different frameworks that the theme is known to work with than put the OMF badge and forget about the rest. But just to be clear, I see nothing wrong with specifying several of them as officially supported and recommended, though, if the author chooses to. So far the frameworks are all pretty much compatible, but at some point there will probably be some considerable differences, or there's no reason for them all to coexist simultaneously.

[edouard-lopez]

Thanks for the feedback ! Great to see it's so largely supported.

Context

I reckon @rafaelrinaldi did not target any specific framework but the bare fish (correct me if I'm wrong).

The badge was added by my pull request to add support for oh-my-fish as I did the port to OMF (which I use).

As a result to my contribution @rafaelrinaldi grant me access to its repo recently.

Keep Calm and Carry Coding

@bucaran @bucaran I'm all fair competition and supporting a zillion framework but we may lack the resources to do so and finally give a poor experience to users. We can probably add support for other frameworks, but to do so we need people that can help resolve related issues.

Are you interested ?

[ghost]

Yo. How can I help? Maybe, a PR addressing the issue?

[edouard-lopez]

@bucaran that's a good beginning!

Are you familiar with any of the cited framework?

[ghost]

I think I am familiar :lollipop:

[rafaelrinaldi]

@bucaran Thanks for the heads up. As @edouard-lopez already said, I initially made this theme to work with a raw fish setup (I don't personally use any frameworks). I'm glad to see it is well supported though! Feel free to submit a PR with instructions for installing the theme in all these different frameworks. That would be nice!

[ghost]

Got it and thanks, will do. :+1:

[oranja]

rofl :joy: I am sure @bucaran would love to help with anything related to Fisherman.

I would love to help with Oh-My-Fish. Already suggested to rename the repository to theme-pure and back again to pure, just to create a redirection from theme-pure to pure, which would be very helpful to OMF.

• We are aware that this is not a nice request and working on avoiding this issue, but for now this is our workaround... Edit: oh. I see it in #7 now. Great, thanks @edouard-lopez!

[ghost]

The name of the repository is not a problem. All I am suggesting is adding sections to either explain how to install it in other systems.

I will submit a PR later simply adding instructions for other systems, including fundle.

[oranja]

The name of the repository is not a problem. All I am suggesting is adding sections to either explain how to install it in other systems.

Sadly it is a problem for OMF at this point in time. However, it is also not a problem to change it and then change it back to pure. See #7.

Don't get me wrong, I'll be the first one to +1 your PR with installation instructions for more frameworks.

[rafaelrinaldi]

@oranja I got you covered. Just closed #7 :+1:

[oranja]

Muchas gracias :pray:

[edouard-lopez]

@oranja @bucaran my bad I'm new to fish and just saw you are the main dev behind Fisherman and wahoo :P

[ghost]

@edouard-lopez No problem. I contributed alot to Oh My Fish too.