search

purebred-mua / purebred-email

A fast email parsing library implemented in Haskell
https://hackage.haskell.org/package/purebred-email
GNU Affero General Public License v3.0
23 stars 4 forks source link

Address and Mailbox parsing #12

Closed romanofski closed 6 years ago

romanofski commented 6 years ago

Fixes https://github.com/purebred-mua/purebred/issues/164

romanofski commented 6 years ago

"Finished" it this morning. I'm not sure if I should already file a pull request, but I think I'm nearly done. Should I add more documentation you think? Are there any things which are off and should be improved? Let me know. Real fun to write the parser btw ...

romanofski commented 6 years ago

Updated. Now using decodeLenient from Data.MIME.Charset :)

romanofski commented 6 years ago

Alright. Here we go. New patch, new luck.

romanofski commented 6 years ago

Many thanks for the thorough review. I hope I addressed everything and haven't forgotten any concerns.

frasertweedale commented 6 years ago

OK, I can't see anything wrong with this apart from the known and deliberately deferred encoded-word support. So, merge ho!