search

purebred-mua / purebred-email

A fast email parsing library implemented in Haskell
https://hackage.haskell.org/package/purebred-email
GNU Affero General Public License v3.0
23 stars 4 forks source link

support user-supplied charsets #30

Closed frasertweedale closed 5 years ago

frasertweedale commented 5 years ago

In order to support arbitrary charsets without additional dependencies, add support for user-specific charset lookups. This is an API-breaking change, so bump the major version too.

Fixes: https://github.com/purebred-mua/purebred-email/issues/5

@romanofski I've had this change sitting around for a while, along with a patch for the corresponding updates in purebred, and the prototype ICU plugin that adds support for charsets via libicu. Since we were looking at cutting a new purebred-email release I figure now is a good time to land this change as well. If we decide to land this now, the plan for purebred is:

  1. a minimal change in purebred to use purebred-email-0.2 (with no behavioural change)
  2. the change to add support for charset plugins
  3. publish the ICU plugin as a separate library

If you want to see POC for any of the above before landing this change in purebred-email, fair enough, I can arrange that; just let me know.

romanofski commented 5 years ago

Nah no need for a POC. Just go with it and let me know when you made the version bump, since I need it for my draft changes too :) W00t w00t... looking forward to it :)

frasertweedale commented 5 years ago

Merged to master: 82bc75ff878a61a21a031b155db5e380f3852788