search

purebred-mua / purebred

A terminal based mail user agent based on notmuch
GNU Affero General Public License v3.0
139 stars 19 forks source link

Filebrowser search path could end in a dead end #391

Closed romanofski closed 4 years ago

romanofski commented 4 years ago

Describe the bug Changing the search path in the file browser could have unforeseen consequences if we're using the editor. So far I was unable to open a gate to the fourth dimension. I'm still trying however.

To Reproduce Steps to reproduce the behavior:

  1. Compose an e-mail.
  2. Open the file browser
  3. Focus the search path editor (using :)
  4. Replace the path with an invalid path and press Escape
  5. Try to move up a parent with CTRL+u. The search path is now set to . and you won't be able to reset it to anything else.

Expected behavior Allow to abort editing, so that the editor reset's it's input state to the previous input.

Screenshots None

Additional context I actually think that almost none of our input fields allow to discard invalid input on user request :/

romanofski commented 4 years ago

With this one I'm giving the Brick filebrowser another attempt. Doesn't have the fancy unicode checkboxes, but I'm not really keen on maintaining our own instance of a file browser with potential problems.