search

purebred-mua / purebred

A terminal based mail user agent based on notmuch
GNU Affero General Public License v3.0
139 stars 19 forks source link

Fall back to previous view in case of an editor error #404

Closed romanofski closed 4 years ago

romanofski commented 4 years ago 
30d9d60 Bump purebred-email to latest 0.4.2 release

Apart from the fixes, we also need the higher package boundaries,
otherwise the nix builds will fail.

eb59fd9 nix: use new release and GHC 8.8.4

This pin's to a new nix release to avoid CI mostly fetching cached
packages instead of rebuilding the (Nix) world.

With bumping minimum versions for vty and brick, the minimum boundaries
of all transitive packages has shifted upwards, causing a lot of
derivations to be rebuilt due to the fact that they are not included in
the package closure of the former pinned versions.

a3b32ce Fall back to previous view in case of editor error

When Purebred is suspended and we hand control over to our editor, it is
possible that the editor errors (crashes, doesn't start, wrong editor,
yadda yadda).

Currently Purebred would simply go to the compose editor with an empty
attachment. That means that we could possibly send an email with an
empty body.

Instead, parameterize the `invokeEditor` function in which we give a
fallback view and widget. In cases of an error, we fall back to this
view and the focused widget.

Fixes: https://github.com/purebred-mua/purebred/issues/336
romanofski commented 4 years ago

Slipped in another patch. Behaviour was bothering me for quite a while when opening HTML attachments with an external browser.

frasertweedale commented 4 years ago

Yee haw!