search

purebred-mua / purebred

A terminal based mail user agent based on notmuch
GNU Affero General Public License v3.0
139 stars 19 forks source link

Mail is still `sent` even if an error occurs #418

Closed romanofski closed 3 years ago

romanofski commented 3 years ago

Describe the bug When an error occurs in the sendmail function, the error is displayed alright, but the mail is still shuffled away into the Sent folder while I find myself back at the index view.

To Reproduce Steps to reproduce the behavior:

  1. Change the path in the _cvSendMailCmd to something bogus so it errors
  2. Compose a mail and press send
  3. The mail is indexed and created in the Sent folder, but it obviously hasn't been sent at all

Expected behavior I remain on the composition view and the error is displayed.

Screenshots Easy to reproduce.

Additional context I presume the current pass is like the quickest hack we were able to get away with, but it's obviously not really good.

frasertweedale commented 3 years ago

Yeah, we need to handle this better. Thanks for filing the ticket.

frasertweedale commented 3 years ago

I'll take this one.