search

purebred-mua / purebred

A terminal based mail user agent based on notmuch
GNU Affero General Public License v3.0
139 stars 19 forks source link

group reply #425

Closed frasertweedale closed 2 years ago

frasertweedale commented 3 years ago

Implement group reply (#419). Requires https://github.com/purebred-mua/purebred-email/pull/63.

Also fix a bug where non-ASCII headers were presented with raw encoded-words when replying. This affected UI only, but was quite annoying.

88842ca (Fraser Tweedale, 2 days ago)
   add group reply

   Implement the group reply action and bind it to 'R'.

   Fixes: https://github.com/purebred-mua/purebred/issues/419

ed56ed5 (Fraser Tweedale, 3 days ago)
   reply: render non-ASCII headers properly

   When replying, purebred does not perform encoded-word decoding of the
   values of the To/From/Subject header fields.  As a consequence, raw
   encoded-words can appear in these values.

   Use the specific header optics provided by purebred-email and remove our
   buggy and unneeded helper functions.  As a result, headers with 
   encoded-words are presented with the values decoded.

   Also add a regression test to UAT suite.

55ae926 (Fraser Tweedale, 7 weeks ago)
   use purebred-email 0.5

   Bump to purebred-email 0.5.  Note the following:

   - Outbound mail now uses zoned time in the `Date` header.

   - Replying now uses the new `Data.RFC5322.reply` function.  This
    results in possible different rendering of the From/To/Cc fields
    of the reply.  For example, see the UAT changes in this commit.

   - If user has not set cvIdentities, a reply will be constructed with
    the default `From` address `CHANGE.ME@YOUR.DOMAIN`.
    `Data.RFC5322.reply` requires a `NonEmpty` list of author
    mailboxes because RFC 5322 requires all messages to have a `From`
    field.  A future change could use info from the environment to
    construct a better default email, but for now we just use this
    hardcoded, in-your-face default.
frasertweedale commented 3 years ago

Not to be merged until purebred-0.5 has been released, and CI is green.

frasertweedale commented 2 years ago

I suppose I should get around to doing a purebred-email release, updating this branch and merging.

romanofski commented 2 years ago

Yes please so we could actually do a release in the hope perhaps more people join and contribute :)

frasertweedale commented 2 years ago

@romanofski CI is green except for nix jobs. Do you want to review, or should I just press merge button?

frasertweedale commented 2 years ago

This PR is now based on top of #441, which should be reviewed and merged first.

romanofski commented 2 years ago

@romanofski CI is green except for nix jobs. Do you want to review, or should I just press merge button?

Happy to merge whenever. GHC and the other PR is already in. I can fix the Nix stuff up after you've merged if you want.