refactor: remove Toggleable from db functions

purebred-mua / purebred

A terminal based mail user agent based on notmuch

GNU Affero General Public License v3.0

139 stars 19 forks source link

refactor: remove Toggleable from db functions #470

Closed frasertweedale closed 2 years ago

frasertweedale commented 2 years ago

The current database query functions return lists of Toggleable thread/message. But this concept doesn't belong in the database API. Push the construction of the Toggleable value down to the UI code, applied to the result of the database queries.

romanofski commented 2 years ago

There are two tests which seem to fail consistently - you want to investigate?

frasertweedale commented 2 years ago

@romanofski the only jobs that are failing are the GHC 9.4 tests (allowed to fail; caused by vty not supporting GHC 9.4 yet), and the NixOS jobs. Apart from that it's just the usual test flakiness.