search

purebred-mua / purebred

A terminal based mail user agent based on notmuch
GNU Affero General Public License v3.0
139 stars 19 forks source link

fix flake when removing xapian directory #502

Closed romanofski closed 1 year ago

romanofski commented 1 year ago

On CI we ran into an error during tearDown:

file browser handles invalid path input:                  FAIL
    Exception: /tmp/purebredtest-a77e114bdea2381d/Maildir/.notmuch/xapian: removeDirectoryRecursive:removeContentsRecursive:removePathRecursive:removeContentsRecursive:removePathRecursive:removeContentsRecursive:removeDirectory: unsatisfied constraints (Directory not empty)
    Use -p '/file browser handles invalid path input/' to rerun this test only.

The function removeDirectoryRecursive will not delete files marked as read only. However the removePathForcibly will change read only files in order to force remove the directory.

frasertweedale commented 1 year ago

According to https://hackage.haskell.org/package/directory-1.3.8.0/docs/System-Directory.html#v:removePathForcibly , removePathForcibly was introduced in directory-1.2.7.0. Can you please bump the lower bound in the cabal file?

Apart from that, LGTM.