search

purekid / mongodm

MongoDB ORM that includes support for references,embed and multilevel inheritance.
MIT License
200 stars 47 forks source link

[Insight] Boolean property should not be prefixed by "is" #61

Closed jrschumacher closed 10 years ago

jrschumacher commented 10 years ago

in src/Purekid/Mongodm/Model.php, line 675

Boolean property accessor should not be setIsXXX nor getIsXXX but setXXX and isXXX.

     *
     * @param bool $is_embed
     *
     * @return null
     */
    public function setIsEmbed($is_embed)
    {
        $this->_isEmbed = $is_embed;
        if ($is_embed) {
            unset($this->_connection);
            unset($this->exist);

Posted from SensioLabsInsight

jrschumacher commented 10 years ago

Need to determine how this is used so we can see if it can be changed or needs to be deprecated.