Closed dkaszews closed 2 years ago
There's no way I'm going to make the tests work in neovim.
Why not? Even if passing all the tests is not realistic, the changes I listed are enough to pass most of them. The PR contribution guidelines already ask if you have tested your changes on vim and neovim, so not being able to run anything over such small issues is a bit weird. We can still treat testing on neovim as optional, but being able to write a new test for small change definitely improves developer experience.
I will create a PR to show the changes I needed for #639 tests to pass.
Added PR. Also, I understand your attitude that since you don't use NeoVim yourself, you don't have incentive to fix it. But that's what open source is for - just allow me to help where I can 🙂
Apologies I didn't realise you were sending a PR. I read this as "Bug in Vimspector: tests don't work in neovim" which is not a bug, because they were never intended to! My position on neovim support is that if someone wants to contribute and maintain support, then I'm OPEN ARMS, but I have little time or impetus to do so myself - I simply have to draw the line somewhere - I maintain vimspector and YCM in very limited free time.
Regarding supporting neovim tests, then I would like the CI system to run them in a repeatable container (like the vim tests) and for them to all pass, or be skipped. I'll take a look at the PR, thanks!
It may be a culture issue - at my company every PR must be linked with an issue. Maybe I should have used the feature template but I thought bug is more appropriate as the feature already exists, just doesn't work on some configs.
I take it that if I don't need to discuss something beforehand, I can just create a PR and skip the issue?
at my company every PR must be linked with an issue
sure it makes sense, and I thank you for doing it! I only saw the issue not the PR.
if you want to discuss changes, then you can reach me direct on matrix/gitter - usually easier to chat in my experience :)
Description
I know NeoVim support is experimental, but developing #639 I wanted to also test it aside from regular vim and noticed some very simple issues:
--not-a-term
- from my observations can be omitted, neovim has similar option--headless
but it does not render the window at all, which may break some testsch_logfile
,test_override
,popup_close
- non-critical, can be omited if not existv:none
- usev:null
supported by both vim and NeovimFixing those couple things allowed me to pass most tests on NeoVim. Some still fail on asserting current buffer or line for unclear reasons, but it's still better than nothing.
Works in vim?
Only broken in Neovim
Works with clean config?
Yes
Sample project works?
No sample project for this filetype
Minimal Reproduction
vim
toneovim
or modifyrun_tests:RUN_VIM
Add minimal test `tests/neovim.test.vim:
run_tests neovim.test.vim
Expected Behaviour
Test passes
Actual Behaviour
Multiple errors in order of fixes:
vim: Unknown option argument "--not-a-term"
E117: Unknown function: ch_logfile
E117: Unknown function: test_override
E121: Unknown variable: v:none
E117: Unknown function: popup_close
Additional information
No response
Installation Type
Plugin Manager (git clone)
Vimspector version
ce7ae8b
Debug Info
No response
Log file
No response
Vim version