search

puremourning / vimspector

vimspector - A multi-language debugging system for Vim
http://puremourning.github.io/vimspector-web
Apache License 2.0
4.08k stars 171 forks source link

Check capabilities before sending instruction breakpoints #855

Closed samisalreadytaken closed 4 months ago

samisalreadytaken commented 4 months ago

Servers can support disassembly without instruction breakpoints.

puremourning commented 4 months ago

This change is Reviewable

samisalreadytaken commented 4 months ago

It is the case in my currently unreleased server. It's caused by the lack of debugger interface on instruction execution while the instructions themselves and instruction pointers are accessible.

The simplest way to test locally would be to use a server that supports disassembly, and ignore/remove the supportsInstructionBreakpoints capability on handle_initialize_response() (and OnEvent_capabilities() if that server fires that event).

mergify[bot] commented 4 months ago

Thanks for sending a PR!

mergify[bot] commented 4 months ago

Thanks for sending a PR!