nextUrl is parsed with URL while it should be parsed with URI

purepennons / gss

Automatically exported from code.google.com/p/gss

Other

0 stars 0 forks source link

nextUrl is parsed with URL while it should be parsed with URI #1

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?

1. Call the gr.ebs.gss.server.Login servlet with the parameter 
next=chrome://something
2. Assuming you have an account, login
3. You will get a 500 error (MalformedURLException)

I noticed at the Login code that you use java.net.URL to parse nextUrl while 
semantically it may 
be more appropriate to use URI. Using URL leads to the error above since the 
underlying 
implementation of URL expects some UrlHandler to exist, while chrome has no 
handler. This of 
course will fail for any other fictitious protocol.

I use the chrome protocol for the Pithos Client on top of a Firefox extension. 
Normally, after the 
login, I want to be redirected to my XUL UI, which will have a chrome:// URL.

Original issue reported on code.google.com by loverdos on 15 Jul 2009 at 1:31

GoogleCodeExporter commented 8 years ago

For those in the loop it is obvious, but just for completeness, the pithos 
service used to obtain the above is 
http://pithos.grnet.gr/pithos

Original comment by loverdos on 15 Jul 2009 at 1:50

GoogleCodeExporter commented 8 years ago

Sounds reasonable, assuming that the extension will have access to the cookie 
stored
by the server. We will investigate whether this will work, but in the meantime 
you
could use the second method for authenticating users that is suitable for all 
kinds
of desktop clients.

Original comment by past...@gmail.com on 16 Jul 2009 at 6:18

GoogleCodeExporter commented 8 years ago

Original comment by past...@gmail.com on 3 Aug 2009 at 9:59

Changed state: Accepted
Added labels: Type-Enhancement
Removed labels: Type-Defect

GoogleCodeExporter commented 8 years ago

Fixed in changeset e68452e97095aa31a753efca55635ebb0e94a610.

Original comment by past...@gmail.com on 4 Aug 2009 at 10:28

Changed state: Fixed

GoogleCodeExporter commented 8 years ago

Apparently this change won't help for a Firefox extension:

http://groups.google.com/group/mozilla.dev.extensions/browse_thread/thread/126f2
2b04590
666f#

Original comment by past...@gmail.com on 5 Aug 2009 at 7:44

Changed state: Verified