search

purescript-concur / purescript-concur-core

Concur UI library for Purescript. Core framework.
MIT License
30 stars 10 forks source link

Integrate performance enhancement changes. #25

Closed ajbarber closed 1 year ago

ajbarber commented 1 year ago

Will require lockstep merge of same branch in purescript-concur-react.

ajnsit commented 1 year ago

Thanks @ajbarber! This is looking really good! I have merged this PR. I will soon (within a couple of days hopefully) merge the PR for concur-react as well.

Now that Aff is not integral to this code, I think we can drop that dependency.

I have made that and a bunch of other changes on top of your changes. The changelog looks like this -

  1. Cancelers don't return remaining widgets anymore. This was unused and therefore an unnecessary complexity.
  2. Remove extra dependencies. Especially a dependency on Aff.
  3. Remove old unused code.
  4. Remove code that I feel should go to separate packages.
  5. Cleanup a lot of code.
  6. Format.