purescript-contrib / governance

Guidelines and resources for the PureScript Contributors organization
15 stars 3 forks source link

purescript-long? #42

Closed jamesdbrock closed 2 years ago

jamesdbrock commented 3 years ago

This package https://github.com/zapph/purescript-longs

has important features but it gives me lots of trouble because of the way it’s organized. Also the package is not receiving any attention from its author.

How would we feel about a purescript-contrib/purescript-long package which is basically the same thing, but with types Long and ULong instead of of the parameterized types Long Signed and Long Unsigned?

jamesdbrock commented 3 years ago

This all depends on https://www.npmjs.com/package/long , so maybe it's not a good choice for inclusion in purescript-contrib?

JordanMartinez commented 3 years ago

I think I'd be ok with this. It may be wrapping a JS library, but it is also providing "core data types" similar to the other ones that were transferred recently. Plus, the contrib org isn't the core libraries.

jamesdbrock commented 2 years ago

I've written a replacement for purescript-long called purescript-int64. I intend to add it to contrib, is that cool?

https://github.com/jamesdbrock/purescript-int64

This package has no NPM.js dependencies, instead I've just copied the NPM code into this package. https://github.com/jamesdbrock/purescript-int64/tree/main/src/Data/Internal/long.js

This would go along with our other packages for “core data types”:

jamesdbrock commented 2 years ago

Published https://github.com/purescript-contrib/purescript-int64

JordanMartinez commented 2 years ago

Thanks James!