search

purescript-contrib / governance

Guidelines and resources for the PureScript Contributors organization
15 stars 3 forks source link

Add command to sync all labels across core, contrib, web, and node libs #49

Closed JordanMartinez closed 2 years ago

JordanMartinez commented 2 years ago

See https://github.com/purescript/governance/issues/5

JordanMartinez commented 2 years ago

At this point, we just need to define the descriptions for each label and confirm that the colors are what we want.

JordanMartinez commented 2 years ago

@garyb Any thoughts on the labels here, their colors, and descriptions?

garyb commented 2 years ago

Looks like we're missing the accepted status, and I thought you said duplicate wasn't really very useful? 🙂

JordanMartinez commented 2 years ago

Looks like we're missing the accepted status,

Oh, whoops! I've added it.

I thought you said duplicate wasn't really very useful?

Well, no. At the end I said:

However, excluding such issues by using that approach would also remove issues that have "duplicated" somewhere in their title or content.

All that to say, yes, I think this should be added.

garyb commented 2 years ago

Ah right, sorry! I apparently didn't read that part properly 🤦‍♂️.

Do you think we need a description for "question"? It's probably self explanatory enough.

I think the rest of it looks good to me, I have no particularly strong feelings about the colours. If they're different from the ones we use in purescript/purescript (or other places they may already exist) we'll get used to them quickly enough anyway. :smile:

JordanMartinez commented 2 years ago

I mean... I kind of think question should be replaced with documentation. If someone is asking a question, it's usually best documented somewhere in the repo or the question should be asked on Discourse instead.

Ok, great!

garyb commented 2 years ago

Getting rid of it would be fine by me. I think mostly when I add question tags it's when I'm closing something or just waiting to see if my comment answers it - actual question/discussions that don't lead to specific tasks probably work better on discord/discourse.

JordanMartinez commented 2 years ago

Ok. I'll drop it.

JordanMartinez commented 2 years ago

I just ran the current PR against this repo. Check this repo's labels for what this looks like. For a comparison, see prelude's labels and purescript's labels

JordanMartinez commented 2 years ago

Now that the holiday season is over, is this PR good to merge and run on all repos?

thomashoneyman commented 2 years ago

Let's go ahead. We can bikeshed label descriptions and colors later, as this can be run again at any time (as you noted).

JordanMartinez commented 2 years ago

Ok, I think all repos' labels have been synced. At various times, I got a status message of "Forbidden", so I think I hit GitHub's authenticated rate limit of 5,000 request per hour. So, updating all of these repos may take a few tries by a single person.