purescript-contrib / pulp

A build tool for PureScript projects
GNU Lesser General Public License v3.0
445 stars 86 forks source link

Ctrl-C in `pulp repl` can cause exit #342

Open hdgarrood opened 6 years ago

hdgarrood commented 6 years ago

To reproduce, type pulp repl and then hit Ctrl-C a few times, or hold it down if that doesn't work.

Result:

$ pulp repl
PSCi, version 0.11.7
Type :? for help

import Prelude
> 
> 
purs: Interrupt

Migrated from https://github.com/purescript/purescript/issues/3269

I am pretty sure this is to do with how node handles subprocesses. I think it might be worth investigating how we might be able to get pulp repl to work without having it run as a subprocess of a Node process (ideally in a way which works on Windows too).

nwolverson commented 6 years ago

From looking at subprocesses and signalling before, it's worth bearing in mind (testing with) both the node-wrapped purs bin and the unwrapped one, as that's another layer

muratg commented 5 years ago

FYI: spago repl has the same issue.