search

purescript-contrib / pulp

A build tool for PureScript projects
GNU Lesser General Public License v3.0
445 stars 86 forks source link

Source maps flags conditional for pre/post 0.12 #347

Closed nwolverson closed 6 years ago

nwolverson commented 6 years ago

343

nwolverson commented 6 years ago

Heck of a lot of integration tests failing already on master, I don't feel like diving into that just now

hdgarrood commented 6 years ago

I think #340 should have addressed many of those failures. Would you mind rebasing?

nwolverson commented 6 years ago

Happily, but will be Monday at earliest until I'm in the only of my pc.

On Fri, 8 Jun 2018, 15:41 Harry Garrood, notifications@github.com wrote:

I think #340 https://github.com/purescript-contrib/pulp/pull/340 should have addressed many of those failures. Would you mind rebasing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/purescript-contrib/pulp/pull/347#issuecomment-395782075, or mute the thread https://github.com/notifications/unsubscribe-auth/ACpHy7xEe8_SdzL86fHY9Fxfop2EmMxPks5t6o0PgaJpZM4UO8hI .

hdgarrood commented 6 years ago

Sure thing, no rush!

nwolverson commented 6 years ago

Rebased and CI passed

hdgarrood commented 6 years ago

Looks good, thanks!

bqv commented 6 years ago

Can this be pushed into a release please?

hdgarrood commented 5 years ago

I've just published v12.3.1 which includes this fix. Sorry for the delay!