search

purescript-contrib / pulp

A build tool for PureScript projects
GNU Lesser General Public License v3.0
445 stars 86 forks source link

Allow passing node option to browserify #384

Closed drewolson closed 5 years ago

drewolson commented 5 years ago

This PR allows passing the node option to pulp browserify. This is useful when building a bundle for running on node.

I was unsure about the testing strategy for new features as the integration suite does not seem comprehensive for the browserify command.

drewolson commented 5 years ago

I'm not quite sure how to get CI passing as bower is complaining about conflicting dependency versions. Tests passed locally for me after running bower install.

hdgarrood commented 5 years ago

Thanks for the PR, but I don't think I want to add this, as I'd like to deprecate pulp browserify; see #365. If you need specific arguments to be passed to a JS bundling tool then I'd recommend just running pulp build and then invoking browserify on the output directory directly.

drewolson commented 5 years ago

Makes sense, thanks for the feedback. I'll close this.