search

purescript-contrib / pulp

A build tool for PureScript projects
GNU Lesser General Public License v3.0
445 stars 86 forks source link

Remove main checks #393

Closed garyb closed 4 years ago

hdgarrood commented 4 years ago

I think CI might be failing because we were relying on an older version of argonaut to be pulled in transitively:

[1/1 ModuleNotFound] src/Pulp/Browserify.purs:17:1

  17  import Data.Argonaut (Json, caseJsonArray, caseJsonObject, caseJsonString, fromArray, fromObject, fromString, jsonEmptyObject, jsonNull, jsonParser)

      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  Module Data.Argonaut was not found.

  Make sure the source file exists, and that it has been provided as an input to the compiler.
garyb commented 4 years ago

Seems so, yeah. Odd that it didn't break locally. 🤔

garyb commented 4 years ago

Oh, mystery solved: I removed the externs-check dependency after the other changes, and didn't re-install bower dependencies after, and that's where the transitive argonaut dependency was coming from.

hdgarrood commented 4 years ago

I've just published v15.0.0 with this fix included.