search

purescript-contrib / purescript-affjax

An asynchronous AJAX library built using Aff.
Apache License 2.0
121 stars 78 forks source link

Fix the script got stuck when request timed out #132

Closed acple closed 5 years ago

acple commented 5 years ago

I found a critical issue that deadlocking scripts.

For example, on client PC that placed on very unstable wireless network, Google Chrome rarely raises net::ERR_TIMED_OUT from xhr. Now Affjax does not handle a timeout path, then script gets stuck eternally, a continuation will be discarded. I think xhr timeout must be handled with error callback.

And sorry I didn't know how to reproduce this, but I confirmed that this patch fixed the title issue by actual environment.

purs 0.12.2 Google Chrome Version 72.0.3626.81 (Official Build) (64-bit) purescript-affjax with purescript-halogen

garyb commented 5 years ago

Thanks! Sorry merging took a while.