search

purescript-contrib / purescript-affjax

An asynchronous AJAX library built using Aff.
Apache License 2.0
122 stars 79 forks source link

Provide an option for configuring `xhr.timeout` #143

Closed paluh closed 4 years ago

paluh commented 5 years ago

It seems that both xhr2 and browsers support a timeout option. Should I provide a PR which adds this option to the Request (I mean timeout :: Milliseconds) type?

chekoopa commented 4 years ago

Affjax previously has timeout parameter as a part of RetryPolicy, which was mistakenly removed with [d710d92a46f8afb165214be07d452fd586c78c0d] (@garyb, you weren't right, we are using them actively to control backend connections, even retries).

So, yes, that PR would be pretty neat.

chekoopa commented 4 years ago

Bump. :confused:

We're still pinning v9.0.0 as for lack of timeouts.