search

purescript-contrib / purescript-bigints

Arbitrary length integers for PureScript
MIT License
26 stars 22 forks source link

Since JavaScript now has BigInt as a primitive type, should not purescript also support BigInt as a primitive type. #24

Closed ghost closed 3 years ago

ghost commented 4 years ago

The BigInt's in purescript are very slow, since they are wrappers around a BigInteger.js module. Since JavaScript now supports BigInts as primitive types, should not PureScript also support BigInt natively using FFI, instead of these wrappers.

sharkdp commented 4 years ago

Maybe, but I guess it's better to discuss this on the PureScript repo.

triallax commented 4 years ago

@vamsikal3 I just want to point out that BigInteger.js actually uses native JavaScript BigInts under the hood when they are available in the environment. You can see that in BigInteger.js's README.

Additionally, a lot of people use old browsers or ones that still don't support BigInt.

radrow commented 3 years ago

I totally agree, but this is not an issue to be solved in this repo, but rather in the PS itself

triallax commented 3 years ago

@radrow purescript/purescript#3848

triallax commented 3 years ago

Any reason this issue is still open? Like @sharkdp and @radrow said, this is not the appropriate repo for this issue.