purescript-contrib / purescript-bigints

Arbitrary length integers for PureScript
MIT License
26 stars 22 forks source link

Update for PureScript 0.14 #33

Closed thomashoneyman closed 3 years ago

thomashoneyman commented 3 years ago

This PR updates the library dependencies and tests for PureScript 0.14.

If everything looks good, we'll want to make a major version release of this library and I can then take care of updating this in the package sets for you.

sharkdp commented 3 years ago

Tested locally, looks great. Thank you very much!

Tagged as v5.0.0

sharkdp commented 3 years ago

@thomashoneyman If you are interested, I can give you full write permissions to this repository. Unfortunately, I'm not that active in the PureScript community anymore (even though I still write some PureScript from time to time :smile:). And I don't have any other projects that depend on this library.

If you would prefer that, we can also move the repository somewhere else.

Or we can just keep things as they are.

Edit: similar for purescript-decimals. The only difference is that I do care a lot more about -decimals, as it's a dependency of purescript-quantities and Insect.

thomashoneyman commented 3 years ago

@sharkdp If you give me write permissions to this repository (and -decimals) then I can loop back to update them for compiler releases, though I'll otherwise avoid making any major changes to your work.

If you would like either of these libraries migrated into contrib we can also discuss that, though we've instituted a policy that libraries have to have a maintainer to be migrated in and I'd have to see if anyone is interested (or if I have the time). That does carry the cost that the libraries would no longer be under your account, though, which makes it less clear that you are the author. On the other hand, it means you don't have to worry about them!

If you don't feel strongly one way or another, then we could start with write access and take bigger steps if desired later.

sharkdp commented 3 years ago

@sharkdp If you give me write permissions to this repository (and -decimals) then I can loop back to update them for compiler releases, though I'll otherwise avoid making any major changes to your work.

Awesome. Thank you very much. I invited you collaborate on both repositories.

I didn't want to imply that major/breaking changes should not be made. It's only that I would still like to keep up to date with them, I believe. And please feel free to make other (minor) changes as you like.

If you don't feel strongly one way or another, then we could start with write access and take bigger steps if desired later.

Sounds great.