Closed sigma-andex closed 2 years ago
@sharkdp this test failed and only passes with the change made. I am not sure whether this correct.
@sharkdp this test failed and only passes with the change made. I am not sure whether this correct.
well, that is.. unexpected? Are there some upstream changes that would indicate a breaking change?
@sharkdp this test failed and only passes with the change made. I am not sure whether this correct.
well, that is.. unexpected? Are there some upstream changes that would indicate a breaking change?
I haven't found anything... not sure what to think about this.
Apart from that, the 0.15 update is now complete
@sigma-andex Is this PR using spago@0.20.8
now?
Also, mind adding a ToString
for BigInt
, which can reflect type-level Int
s to a BigInt
? Something like this should work:
import Prim.Int (class ToString)
import Data.Reflectable (class Reflectable)
reflectBigInt :: forall i. ToString i sym => Reflectable sym String => Proxy i -> BigInt
reflectBigInt p = fromString $ reflectType p
import Prim.Int (class ToString) import Data.Reflectable (class Reflectable)
Not sure if this is possible, fromString
returns a Maybe
import Prim.Int (class ToString) import Data.Reflectable (class Reflectable)
Not sure if this is possible,
fromString
returns aMaybe
fromString
has to return Maybe
because it must work on all String
types. However, if we can guarantee that the String
type stores an integer, which it does in this case, then we don't need that Maybe
.
So, we should actually just use fromBase
here, but without the Maybe
wrapper. In other words, exposing FFI to just this function and using that in the implementation.
This PR should now be ready to go.
Thx @JordanMartinez