Open mikesol opened 2 years ago
Yes, it would be good to make sure we're accurately capturing the available arguments for this. Thanks!
The downside is that it is a breaking change, so when folks upgrade their code wouldn't compile anymore. How would you like to handle that? We could make a new animateWithPlayState
function, for example, that takes the additional argument. That wouldn't break anything. Lemme know!
With breaking changes, we tend to accept the PR but wait to merge it until we're ready for a breaking release. In this case we'd be waiting for a long time because there's no breaking release planned. However, I'm open to animateWithPlayState
as well!
Currently,
animation
leaves off the last parameter that corresponds toanimation-play-state
. It would be nice if the API included this as well. I have a forked version where I've incorporated that and it works fine - the code is pasted below. It usesAnimationPlayState
for the type and then increases the number of arguments toanimation
by one.Would folks be interested in incorporating this into the library?