Added table selector - Githubissues

purescript-contrib / purescript-css

A clean, type-safe library for describing, manipulating and rendering CSS

Apache License 2.0

105 stars 39 forks source link

Added table selector #141

Closed plurip-software closed 2 years ago

plurip-software commented 2 years ago

Missing Table Selector

While using purescript-halogen-css I became aware of the non-existance of a separate table selector.

Checklist:

[ x] Added specific table selector as 'table_' (table wasn't available as a function name since it is already used for the ' display table' in CSS.Display).

nsaunders commented 2 years ago

Hi @plurip-software, thanks for your submission.

Regarding the name conflict, I really appreciate that you maintained backward compatibility by preserving the existing function name. However, since we have other breaking API changes in the pipeline anyway (as of today), it seems like now might be a good time to resolve that conflict by renaming the existing table function to displayTable (as has been done in Clay). What do you think?

plurip-software commented 2 years ago

Sounds good !

nsaunders commented 2 years ago

Excellent, thanks @plurip-software. Would you be interested in adding another commit to make that change? If not, I can do it for you. Just let me know!

plurip-software commented 2 years ago

I will do it ! I'm pretty new to collaborating on GitHub, so I hope I don't mess something up^^

nsaunders commented 2 years ago

Looks great -- thanks!