search

purescript-contrib / purescript-css

A clean, type-safe library for describing, manipulating and rendering CSS
Apache License 2.0
106 stars 40 forks source link

flex-grow and flex-shrink typed as `Number` #64

Closed andywhite37 closed 3 years ago

andywhite37 commented 7 years ago

The flex shorthand, flex-grow, and flex-shrink properties appear to allow Numbers as values, not just Ints. I ran into this tonight while trying to implement a flex-based slider control.

See below:

https://drafts.csswg.org/css-flexbox-1/#flex-property

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

andywhite37 commented 5 years ago

Hello, I just discovered I had this long-forgotten open pull request. It's just a tiny change, and not likely to make much of a difference, but I just got it up-to-date with master, so it should be mergable.

thomashoneyman commented 3 years ago

I see that flex can take number values, not just integers, as in your link (https://drafts.csswg.org/css-flexbox-1/#flex-property) and Mozilla (https://developer.mozilla.org/en-US/docs/Web/CSS/flex). I think this is reasonable.

JordanMartinez commented 3 years ago

@andywhite37 Could you add a summary of this change in the "Breaking Changes" section of this repo's CHANGELOG.md file? We should merge after that.

andywhite37 commented 3 years ago

@JordanMartinez - done, let me know if that looks okay. Thanks to you and @thomashoneyman for noticing this PR - it was no big deal, but happy to see it get merged!

JordanMartinez commented 3 years ago

Thanks!