search

purescript-contrib / purescript-css

A clean, type-safe library for describing, manipulating and rendering CSS
Apache License 2.0
106 stars 40 forks source link

Added all CSS animation timing functions #74

Closed machinedgod closed 2 years ago

machinedgod commented 6 years ago

Following the W3C reference residing here: https://www.w3schools.com/cssref/css3_pr_animation-timing-function.asp

P.S. The string concatenation is done naively with (<>) operator. It might be cleaner to refactor to some higher level formatting function.

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

machinedgod commented 6 years ago

Please excuse if formatting or style (or something else) isn't in line with the rest of the codebase. Given guidance, I'll fix what's necessary.

decorator-factory commented 3 years ago

Hi, what's the state of this PR? I wanted to contribute an interface to allow easily adding transitions, that I'm using in my project:

transition
  [ easeInOut "color" 0.25
  , cubicBezier 0.95 (-0.33) 0.8 0.84 "font-size" 0.3
  ]

do you mind if I override this PR?

machinedgod commented 3 years ago

Hi, I honestly don't know what the state is, I did it for myself because I needed it, and just made a PR to contribute back.

By all means, please feel free to override it!

JordanMartinez commented 3 years ago

We'd likely return to this PR once v0.14.0 comes out.

Wow... 2018. This was opened quite a while ago.

JordanMartinez commented 3 years ago

Just FYI. I'm going through old PRs and will be getting to this later on this week.

machinedgod commented 3 years ago

Oh my, this is an old PR :-) Please let me know if something needs to be brought up to date and/or changed.

P.S. Worth be checking with the other poster, if they made a better code, and abandoning this.

nsaunders commented 2 years ago

Thanks for your submission @machinedgod. This was a good PR, but it appears that these transitions were already added at a different point in time. Closing for now... Please let me know if I've missed something!