Update to v0.14.0-rc3 - Githubissues

purescript-contrib / purescript-formatters

Formatting and printing for numeric and date/time/interval values

Apache License 2.0

41 stars 30 forks source link

Closed JordanMartinez closed 3 years ago

JordanMartinez commented 3 years ago

Backlinking to purescript-contrib/governance#35

JordanMartinez commented 3 years ago

This still won't build because it relies on Spec. It'll take a bit more work to update completely.

JordanMartinez commented 3 years ago

This should pass now, but it uses MonadZero's guard. What should that function be replaced with now?

garyb commented 3 years ago

There's an Alternative-constrained guard now that should work I think?

JordanMartinez commented 3 years ago

Yup, that works. I've updated this PR.

thomashoneyman commented 3 years ago

Could we add the dependency changes to the changelog?

JordanMartinez commented 3 years ago

How's that? Or did you mean something more than that?

JordanMartinez commented 3 years ago

I'm actually not sure that numbers is needed as it's likely pulled in via a transitive dependency