Fix warnings revealed by PureScript v0.14.1

purescript-contrib / purescript-formatters

Formatting and printing for numeric and date/time/interval values

Apache License 2.0

41 stars 29 forks source link

Fix warnings revealed by PureScript v0.14.1 #68

Closed purefunctor closed 3 years ago

purefunctor commented 3 years ago

Description of the change Links to purescript-contrib/governance#37

Checklist:

[x] Added the change to the changelog's "Unreleased" section with a link to this PR and your username
[ ] Linked any existing issues or proposals that this pull request should close
[ ] Updated or added relevant documentation in the README and/or documentation directory
[ ] Added a test for the contribution (if applicable)

purefunctor commented 3 years ago

Not entirely sure what to do with: https://github.com/purescript-contrib/purescript-formatters/blob/6347c2c50b78445f0a10ed2496fddbdf4e3d382a/test/src/DateTime.purs#L200-L201 Should this be removed or exported?

JordanMartinez commented 3 years ago

What does git blame show for that? If it's not being used, it was likely there when someone was debugging the code or something. I'm leaning towards removing it.

natefaubion commented 3 years ago

It should be removed.

purefunctor commented 3 years ago

What does git blame show for that? If it's not being used, it was likely there when someone was debugging the code or something. I'm leaning towards removing it.

It points to (a squashed) #17; that seems to be the case though so I went ahead and removed it