Closed ntwilson closed 3 years ago
Yes! PRs fixing warnings are very much welcome throughout the contrib libraries. For unused names I would generally omit them altogether with _.
Ugh, I'm sorry I misread the build output, and this library has no warnings, it's all in the dependencies. I'll close this issue and thank you for the instruction. I'll focus any effort on the upstream contrib libraries.
Currently, building master of this library with 0.14.2 yields 69 warnings (mostly from use of
MonadZero
and from unused names). Would a PR that fixes these warnings be welcome? If so, for unused names, would it be preferable to prefix with_
or replace the whole unused name with_
, or best judgement case-by-case?