search

purescript-contrib / purescript-formatters

Formatting and printing for numeric and date/time/interval values
Apache License 2.0
41 stars 29 forks source link

Localization #85

Open CarstenKoenig opened 1 year ago

CarstenKoenig commented 1 year ago

Hi,

I'm actually not sure if this is an issue at all (meaning if there is not already a workaround I don't see - if so sorry) - but here we go:

I happen to write apps mainly for German speaking folks and here it's not 1,123.45 it's 1.123,45 (yeah stupid but hey 🤷). It's not really a big deal as some simple replacing afterwards fixes this but still folks might be interested in having this in the library.

Proposed solution I think having optional parameters for the thousand- and decimal-separator-characters defaulting to those here for the number-Formatter might be a good start.

I'd happily volunteer to implement such a change if you are interested in it.

What do you think?

garyb commented 1 year ago

Sounds good to me :+1:

CarstenKoenig commented 1 year ago

all right - I'll give it a try - thanks