search

purescript-contrib / purescript-profunctor-lenses

Pure profunctor lenses
MIT License
144 stars 52 forks source link

Instances for HashMap #107

Closed drewolson closed 5 years ago

drewolson commented 5 years ago

I noticed that many of the optics in this package have instances for Map but not for HashMap. I would find it useful to have access to Ix and At (among others) for HashMaps. Would you be willing to accept a PR for this?

garyb commented 5 years ago

I'd prefer if we added the instances there instead perhaps, since this library is in contrib, and we tend not to add dependencies on things outside of core/contrib. That ensures we can keep the libraries up to date - when we have external dependencies, it's possible that dependencies go stale, or the owner is too busy to review/merge updates when we're trying to update things here, etc.

drewolson commented 5 years ago

Makes sense, thanks.