I wanted to make it easier to add automated tests, and so I started by converting the manual ones that already existed.
Working from the principles of iterative improvement, this PR is not perfect but I'm quite sure it is better then the code that existed, and hope the next person (maybe me) will improve it further.
The asserts did not get good names since I don't know what they intended with the test, but at least they are easy to find due to the unique names they have, since they are named by the expression it tests.
Checklist:
[x] Added the change to the changelog's "Unreleased" section with a link to this PR and your username
[x] Linked any existing issues or proposals that this pull request should close
[x] Updated or added relevant documentation in the README and/or documentation directory
[x] Added a test for the contribution (if applicable)
I wanted to make it easier to add automated tests, and so I started by converting the manual ones that already existed.
Working from the principles of iterative improvement, this PR is not perfect but I'm quite sure it is better then the code that existed, and hope the next person (maybe me) will improve it further.
The asserts did not get good names since I don't know what they intended with the test, but at least they are easy to find due to the unique names they have, since they are named by the expression it tests.
Checklist: