purescript-contrib / purescript-quickcheck-laws

QuickCheck powered law tests for PureScript's core typeclasses.
MIT License
25 stars 18 forks source link

Use an extensible effects type. #10

Closed rgrempel closed 8 years ago

rgrempel commented 8 years ago

I thought it would be nice to re-use your module to help test my own code.

However, I had some difficulty integrating your code with other test code, because of the closed row of effects. So, I've modified each check... function to use an extensible row of effects.

For an example of how I'm using this, see:

https://github.com/rgrempel/purescript-elm/blob/master/test/Elm/Int53Test.purs#L72-L78

Of course, if there's a better way to re-use this code, that would be fine with me too!

garyb commented 8 years ago

Thanks! There's not particular reason this should be a closed row, I probably just didn't think carefully enough about other use cases. I'll merge and release once Travis is done.