search

purescript-contrib / purescript-quickcheck-laws

QuickCheck powered law tests for PureScript's core typeclasses.
MIT License
25 stars 18 forks source link

Add DivisionRing law checks #37

Closed hdgarrood closed 5 years ago

hdgarrood commented 6 years ago

See https://pursuit.purescript.org/packages/purescript-prelude/3.2.0/docs/Data.DivisionRing#t:DivisionRing

hdgarrood commented 5 years ago

Was this fixed by https://github.com/garyb/purescript-quickcheck-laws/pull/42/commits/88b66b58daaf17dcc6d6444ae3946e5817e17c87?

garyb commented 5 years ago

I guess so! Assuming the checks look good to you?

hdgarrood commented 5 years ago

Yep :) I've left a couple of comments on the commit but they're just minor suggestions.

garyb commented 5 years ago

Thanks, I'll leave them for now but will keep them in mind next time I do an update here. I'm pretty sure there'll be a few other cases like nonZero that only need testing once!