search

purescript-contrib / purescript-quickcheck-laws

QuickCheck powered law tests for PureScript's core typeclasses.
MIT License
25 stars 18 forks source link

Use dependency versions compatible with 0.12 #39

Closed paulyoung closed 6 years ago

paulyoung commented 6 years ago

I think the only remaining issues here are that purescript@0.12 isn't published to npm, and after that there might be a problem if there isn't a version of pulp that works with 0.12

hdgarrood commented 6 years ago

The current version of Pulp should work with 0.12? I know about the pulp init thing but that shouldn’t affect pre existing libraries like this one.

paulyoung commented 6 years ago

@hdgarrood you're right, it does. That was speculation on my part before I got the CI build passing.

Thanks for confirming.

paulyoung commented 6 years ago

Anything else I can do here to help move this along?

garyb commented 6 years ago

No, sorry, I'll get it in soon! I have a branch of my own with changes in too, so wanted to merge the two but have been away / dealing with other libraries so keep forgetting about this.

garyb commented 6 years ago

I'll get this in after the compiler version thing is done, my changes can wait for a future release.

paulyoung commented 6 years ago

@garyb done. Not sure if #41 does anything differently.

thomashoneyman commented 6 years ago

@garyb @paulyoung I don't think my PR does anything differently. It preserves the same functionality but goes through and makes all the necessary 0.12 updates. I'd seen this PR but not that it was cut from the compiler/0.12 branch, and so I think most likely my work is redundant. I can certainly close that if it is superseded by this.

thomashoneyman commented 6 years ago

Well -- I suppose one difference is that CI found an error here! I doubt my implementation is any different, though that one passed.

From CI:

Checking 'Submultiplicative euclidean function' law for EuclideanRing
999/1000 test(s) passed.
/home/travis/build/garyb/purescript-quickcheck-laws/output/Effect.Exception/foreign.js:29
    throw e;
    ^
Error: Test 106 (seed 1442996306) failed: 
Test returned false
    at Object.exports.error (/home/travis/build/garyb/purescript-quickcheck-laws/output/Effect.Exception/foreign.js:8:10)
    at /home/travis/build/garyb/purescript-quickcheck-laws/output/Test.QuickCheck/index.js:139:81
    at /home/travis/build/garyb/purescript-quickcheck-laws/output/Data.Foldable/index.js:95:76
    at /home/travis/build/garyb/purescript-quickcheck-laws/output/Data.Foldable/index.js:292:24
    at /home/travis/build/garyb/purescript-quickcheck-laws/output/Data.Foldable/index.js:417:46
    at /home/travis/build/garyb/purescript-quickcheck-laws/output/Data.Function/index.js:19:24
    at __do (/home/travis/build/garyb/purescript-quickcheck-laws/output/Test.QuickCheck/index.js:138:122)
    at __do (/home/travis/build/garyb/purescript-quickcheck-laws/output/Test.QuickCheck/index.js:169:68)
    at __do (/home/travis/build/garyb/purescript-quickcheck-laws/output/Test.QuickCheck.Laws.Data.EuclideanRing/index.js:77:214)
    at __do (/home/travis/build/garyb/purescript-quickcheck-laws/output/Test.Prim.Int/index.js:27:176)
* ERROR: Subcommand terminated with exit code 1