purescript-contrib / purescript-react

React Bindings for PureScript
MIT License
399 stars 65 forks source link

Relax upper bound on typelevel-prelude #171

Closed hdgarrood closed 5 years ago

hdgarrood commented 5 years ago

To clarify the context of this change: this was originally prompted by https://github.com/purescript/purescript/issues/3502, which then required us to make a breaking change to typelevel-prelude: https://github.com/purescript/purescript-typelevel-prelude/issues/43. Since this library is only using typelevel-prelude for the + row type application operator, there's no need to tighten the lower bound up as we relax the upper bound to allow using the newly released v5.0.0, so I'd suggest releasing this change as a patch-level release to minimize ecosystem disruption.

ethul commented 5 years ago

Thanks for the update. Sounds good to me.

On Mon, May 27, 2019 at 18:20 Harry Garrood notifications@github.com wrote:

To clarify the context of this change: this was originally prompted by purescript/purescript#3502 https://github.com/purescript/purescript/issues/3502, which then required us to make a breaking change to typelevel-prelude: purescript/purescript-typelevel-prelude#43 https://github.com/purescript/purescript-typelevel-prelude/issues/43. Since this library is only using typelevel-prelude for the + row type application operator, there's no need to tighten the lower bound up as we relax the upper bound to allow using the newly released v5.0.0, so I'd suggest releasing this change as a patch-level release to minimize ecosystem disruption.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/purescript-contrib/purescript-react/pull/171?email_source=notifications&email_token=AACVRS7JZYVHMG4XHZ26P5TPXRNCHA5CNFSM4HP53UZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWKSO7Y#issuecomment-496314239, or mute the thread https://github.com/notifications/unsubscribe-auth/AACVRS4T7F6YGWQ34FU6VQDPXRNCHANCNFSM4HP53UZQ .

ethul commented 5 years ago

Thanks for making the release!

On Mon, May 27, 2019 at 19:40 Harry Garrood notifications@github.com wrote:

Merged #171 https://github.com/purescript-contrib/purescript-react/pull/171 into master.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/purescript-contrib/purescript-react/pull/171?email_source=notifications&email_token=AACVRS25ZSEKWMJJ6N3GPG3PXRWNRA5CNFSM4HP53UZ2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORVDYQIY#event-2370275363, or mute the thread https://github.com/notifications/unsubscribe-auth/AACVRSZ6MNWQ6JTCIO5J7JTPXRWNRANCNFSM4HP53UZQ .