purescript-deprecated / gulp-purescript

Gulp plugin providing PureScript compiler tasks
34 stars 8 forks source link

Binaries installed by npm don't seem to work on Windows #21

Closed garyb closed 9 years ago

garyb commented 9 years ago

I'm not exactly sure what the problem is here, I'll try and figure it out when I can, but wanted to make a note so I don't forget. Attempting to use any of the tasks results in this:

events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: spawn Unknown system errno 193
    at errnoException (child_process.js:998:11)
    at Process.ChildProcess._handle.onexit (child_process.js:789:34)
ethul commented 9 years ago

Thanks for the heads up.

I don't have a convenient way to test on windows, but would you be able to try modifying this line to be something like:

child_process.spawn('Full\Windows\Path\To\node.exe ' + bin, args)

I am guessing the issue has something to do with windows not understanding the shabang line.

garyb commented 9 years ago

Ah yep, that looks like it. I had push bin into args, but that works, and in fact, just spawning "node" works:

child_process.spawn('node', [bin].concat(args))
ethul commented 9 years ago

Thanks for the test and confirmation. I will push a patch tonight or tomorrow.

ethul commented 9 years ago

@garyb would you please be able to confirm if the fix is working as expected? I've released it in 0.3.1

Thanks!

garyb commented 9 years ago

Will do! I don't have access to my Windows machine right now but can test this evening.

ethul commented 9 years ago

Great, thanks!

garyb commented 9 years ago

:ok_hand:

ethul commented 9 years ago

Thanks!