search

purescript-deprecated / gulp-purescript

Gulp plugin providing PureScript compiler tasks
34 stars 8 forks source link

Add RTS options reading from argv #57

Closed garyb closed 8 years ago

garyb commented 8 years ago

@ethul how does this look?

garyb commented 8 years ago

Oh, I also added --require-path support in for psc-bundle and fixed a few warnings :smile:

ethul commented 8 years ago

@garyb Looks good! Thanks for the update. Should I merge and make a release?

garyb commented 8 years ago

Yes please!

ethul commented 8 years ago

Just noticed, I think we need the requirePath value added to the list in the pscBundleOptions function. Can you please add this in to the PR?

Also, should we add any documentation about the RTS option? I was looking around and found some info on it here: https://downloads.haskell.org/~ghc/latest/docs/html/users_guide/runtime-control.html

However, do you think there is something else we should use. Or maybe we don't need specific documentation about it. What do you think?

garyb commented 8 years ago

Good catch :smile:

Yeah, I'm not sure how much documentation it needs - if someone has a need to use it they're probably already familiar with the RTS options. I generally have to do a lot of looking up whenever I need to figure out how to use them too, and I've only done basic things like setting the concurrency, memory limit, and debug tracing. You're right that we should mention the fact it exists at all though.

garyb commented 8 years ago

Ok, I've updated the fold and the docs to include the RTS info. We also had a mistake in the existing docs where require-path was listed under psc-bundle rather than psc - I've included it in both and updated the explanation for the psc-bundle usage.

ethul commented 8 years ago

Great! Thanks for the update and the documentation fix.

garyb commented 8 years ago

Thanks for the review and release!

ethul commented 8 years ago

Welcome, thanks for the PR