Closed felixSchl closed 9 years ago
Thanks! Looks good to me. @gbaz Any comments on this?
Looks good to me.
On Thu, Sep 10, 2015 at 7:08 PM, Felix Schlitter notifications@github.com wrote:
Add support for Prim.Char and update the tests
You can view, comment on, or merge this pull request online at:
https://github.com/purescript/purescript-generics/pull/15 Commit Summary
- Add support for
Prim.Char
File Changes
- M src/Data/Generic.purs https://github.com/purescript/purescript-generics/pull/15/files#diff-0 (15)
- M test/Main.purs https://github.com/purescript/purescript-generics/pull/15/files#diff-1 (17)
Patch Links:
- https://github.com/purescript/purescript-generics/pull/15.patch
- https://github.com/purescript/purescript-generics/pull/15.diff
— Reply to this email directly or view it on GitHub https://github.com/purescript/purescript-generics/pull/15.
@garyb Do you know if we added generics
dependencies anywhere in core?
I don't know off the top of my head, and I don't have an up to date version of the script I've been using - I'll check when I get back home (and actually update the repo so other people can use it too).
I think purescript-argonaut-codecs
is the only dependency in core and contrib currently.
Add support for
Prim.Char
and update the tests