search

purescript-deprecated / purescript-generics

21 stars 20 forks source link

Fix #8, add type constructor to SigProd #21

Closed paf31 closed 8 years ago

paf31 commented 8 years ago

@gbaz Could you please review this? Obviously it needs compiler changes, which I'll add after this. I need this to implement an aeson-compatible version of foreign-generic, handling things like Maybe and Either properly.

paf31 commented 8 years ago

This is a breaking change, so I'll merge it with #19, and release everything with compiler version 0.7.6.

gbaz commented 8 years ago

I guess this doesn't fail CI once the base branch is updated? Looks straightforward to me but I guess, yeah, wait for the next release :-)

paf31 commented 8 years ago

Yeah, I think the CI issue is because of the compiler changes needed. I'll release this alongside the compiler.