search

purescript-deprecated / purescript-lens

PureScript implementation of lens
78 stars 15 forks source link

Split #10

Closed joneshf closed 9 years ago

joneshf commented 9 years ago

Alright, I think this is a pretty good split here.

We're down to just const, distributive, either, identity, maybe, and profunctor. As much as I'd like to get rid of profunctor and distributive, they're pretty fundamental. The only modules in here are Lens, Prism, Getter and Setter. The type classes and things went to their own libraries. The rest of the stuff went to purescript-optic. The predefined lenses and prisms went to purescript-refractor. We lost a few things that honestly weren't implemented properly (Rep, Indexable things, Action).

Can someone that cares/uses the library double check this stuff to make sure I didn't miss anything before merging?

Do we need/want to support 0.3.x for a bit (until 1.0.x I'd say)? We can just keep a branch, and push bug fixes (though, there shouldn't be many as it wasn't that complex).

garyb commented 9 years ago

I do care, but haven't had a chance to use lenses yet unfortunately, so can't really help with reviewing aside from saying keep up the good work!

Apologies for dragging heels on updating/releasing the stuff you depend on too, I just totally missed some of the PRs.

paf31 commented 9 years ago

Ditto to everything Gary said ... sorry.

joneshf commented 9 years ago

Oh, no worries. If few people use it, it's less to worry about when breaking things :D

joneshf commented 9 years ago

Oh, these https://github.com/purescript-contrib/purescript-lens/blob/master/src/Control/Lens/Prism.purs#L65-L75 were moved to https://github.com/joneshf/purescript-refractor/blob/master/src/Optic/Refractor/Prism.purs#L9-L19

joneshf commented 9 years ago

Alright, time to make the switch. If anyone still needs updates for 0.3.x it's on that branch.