purescript-deprecated / purescript-lens

PureScript implementation of lens
78 stars 15 forks source link

Correct purescript-profunctors dependency. #14

Closed mjkaye closed 9 years ago

mjkaye commented 9 years ago

This corrects the name of the purescript-profunctors dependency from "purescript-profunctor" to "purescript-profunctors". Without this change, trying to bower install purescript-lens as a dependency of ones project either results in bower trying to retrieve purescript-profunctor from a non-existant mankykitty archive, or bower creating both a "purescript-profuctor" and a "purescript-profunctors" directory. The latter occurs if another dependency itself depends on "purescript-profunctors" and leads to conflicts because both declare the same modules.

garyb commented 9 years ago

Actually, see this: https://github.com/purescript-contrib/purescript-base/commit/4d611157a09e52689aca6530cc997fc34406ebfc#commitcomment-9311570

I'm going to remove purescript-profunctors as more things depend on purescript-profunctor as far as I can tell.

mjkaye commented 9 years ago

Thanks for spotting the naming conflict, garyb. I look forward to seeing its resolution.

joneshf commented 9 years ago

So, does this still need to be merged? Or wait a bit longer?

jdegoes commented 9 years ago

It's dead, I think garby deprecated purescript-profunctors in favor of purescript-profunctor.

joneshf commented 9 years ago

K