search

purescript-deprecated / purescript-lens

PureScript implementation of lens
78 stars 15 forks source link

updates for compiler version 0.12 #37

Closed Thimoteus closed 6 years ago

joneshf commented 6 years ago

The build is failing because the PS version is still 0.11.x. The package.json will also need to be updated.

iAmMrinal0 commented 6 years ago

Can a build be triggered again? It seems to build and tests seem to pass too.

thomashoneyman commented 6 years ago

Looks like the node version in Travis is too old and doesn't support the spread ... operator. That will need to be bumped as well, I believe.

iAmMrinal0 commented 6 years ago

Can I send a separate PR that updates the node version to 8 in travis so that this can be merged?

thomashoneyman commented 6 years ago

@joneshf I'll merge this by end of day today unless you have any objections. Thanks for the work, @Thimoteus, and the reminder @iAmMrinal0!

joneshf commented 6 years ago

No objections. Thanks for taking care of this!

thomashoneyman commented 6 years ago

Merged and released!